New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updateinfo direct command and verbose list (RhBug:1801092) #1607
Conversation
We've discussed this before and it is perhaps subjective, but I'm not convinced hooking additional output data into Would |
It probably is subjective, I would rather have catch-all Nevertheless I am fine with |
Apart from the missing documentation LGTM... |
98e5a5a
to
85b10ee
Compare
Updated the docs. |
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Didn't this have another commit that was removing a You've rebased while pushing the last change so I can't check the diff there... |
@m-blaha I see, thanks! |
📌 Commit 85b10ee has been approved by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually forgot to review the doc update... 🙂
information (``--info``). When the ``-v`` option is used with ``--info``, the | ||
information is even more detailed. | ||
information (``--info``). The ``-v`` option extends the output. When | ||
used with ``--info`` the information is even more detailed. When used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... used with
--info
, the information is ...
(Add a comma)
information is even more detailed. | ||
information (``--info``). The ``-v`` option extends the output. When | ||
used with ``--info`` the information is even more detailed. When used | ||
with ``--list`` additional column with date of last advisory update is added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... with
--list
, an additional column with date of the last advisory update is added.
☀️ Test successful - status-papr |
This changes the output of
updateinfo list
command in verbose mode, while someone might depend on that I think its fine because the original behavior is still present in non verbose mode.(The first commit also fixes a bug with direct commands)
Tests:
rpm-software-management/ci-dnf-stack#809
https://bugzilla.redhat.com/show_bug.cgi?id=1801092