Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic: use email_port specified in config #1956

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

rathann
Copy link
Contributor

@rathann rathann commented Jun 28, 2023

This allows user to override the default SMTP port.

Resolves #1955.

This allows user to override the default SMTP port.

Resolves rpm-software-management#1955.
rathann added a commit to rathann/dnf that referenced this pull request Jun 28, 2023
Add the ability to use STARTTLS/TLS for sending e-mail via the `email`
emitter.

The `email_tls` option supports three settings: ``starttls``, used to
switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to
wrap the entire connection in TLS, usually on port 465. Any other
setting (``off`` by default) will use plain unencrypted SMTP.

Note: this depends on rpm-software-management#1956 .

= changelog =
msg: Add `email_tls` option to DNF Automatic
type: enhancement
resolves: rpm-software-management#1954
@inknos inknos self-requested a review July 24, 2023 10:36
@inknos
Copy link
Contributor

inknos commented Jul 24, 2023

The pr is ok.

I would add a default option in the automatic.conf file.

Also, I would document the option in the reference file.

Could you please add this change?

@inknos
Copy link
Contributor

inknos commented Aug 14, 2023

hi @rathann, any update?

@rathann
Copy link
Contributor Author

rathann commented Aug 15, 2023

Sorry, @inknos, I've been too busy to make the requested changes. I'll try to make some time this week.

rathann added a commit to rathann/dnf that referenced this pull request Aug 15, 2023
Add the ability to use STARTTLS/TLS for sending e-mail via the `email`
emitter.

The `email_tls` option supports three settings: ``starttls``, used to
switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to
wrap the entire connection in TLS, usually on port 465. Any other
setting (``off`` by default) will use plain unencrypted SMTP.

Note: this depends on rpm-software-management#1956 .

= changelog =
msg: Add `email_tls` option to DNF Automatic
type: enhancement
resolves: rpm-software-management#1954
@inknos
Copy link
Contributor

inknos commented Aug 28, 2023

waiting for CI to finish, then looks good to me

@inknos inknos merged commit 727012b into rpm-software-management:master Aug 29, 2023
3 checks passed
rathann added a commit to rathann/dnf that referenced this pull request Aug 31, 2023
Add the ability to use STARTTLS/TLS for sending e-mail via the `email`
emitter.

The `email_tls` option supports three settings: ``starttls``, used to
switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to
wrap the entire connection in TLS, usually on port 465. Any other
setting (``off`` by default) will use plain unencrypted SMTP.

Note: this depends on rpm-software-management#1956 .

= changelog =
msg: Add `email_tls` option to DNF Automatic
type: enhancement
resolves: rpm-software-management#1954
@rathann rathann deleted the issue-1955 branch August 31, 2023 10:11
inknos pushed a commit that referenced this pull request Aug 31, 2023
Add the ability to use STARTTLS/TLS for sending e-mail via the `email`
emitter.

The `email_tls` option supports three settings: ``starttls``, used to
switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to
wrap the entire connection in TLS, usually on port 465. Any other
setting (``off`` by default) will use plain unencrypted SMTP.

Note: this depends on #1956 .

= changelog =
msg: Add `email_tls` option to DNF Automatic
type: enhancement
resolves: #1954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

email_port option supported but not used
2 participants