Include dist-info for python3-dnf #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK to me, I'd just modify the commit message which is saying "Include dist-info for python3-libdnf5". |
|
And what about other packages like |
This is the DNF 4 cousin to this patch [0] for DNF 5. Per [1], Python packages should include some minimal distribution metadata, e.g. to make the package appear in `pip list`. Perhaps the "proper way" to generate this dist-info metadata would be to write a pyproject.toml and use a conventional Python build system like Poetry to build `python3-dnf` rather than doing it with CMake, but this is a way to do it with minimal changes to the build process. Closes RhBug:2239323 [2] [0] rpm-software-management/dnf5#447 [1] https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata, [2] https://bugzilla.redhat.com/show_bug.cgi?id=2239323 = changelog = msg: Add metadata for `dnf` Python package type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2239323
evan-goode
force-pushed
the
evan-goode/dist-info
branch
from
7184349
to
fcd93f4
Compare
evan-goode
changed the title
Whoops thanks!
Sure, I'll PR libdnf. I don't know whether it'd be worth adding metadata to each python3-dnf-plugin. |
jan-kolarik
approved these changes
Oct 9, 2023
evan-goode
pushed a commit
to evan-goode/libdnf
that referenced
this pull request
Oct 9, 2023
This is the libdnf version of this patch [0] for DNF 4. Per [1], Python packages should include some minimal distribution metadata, e.g. to make the package appear in `pip list`. [0] rpm-software-management/dnf#1997 [1] https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata = changelog = msg: Add metadata for `libdnf` Python package type: bugfix
evan-goode
added a commit
to evan-goode/libdnf
that referenced
this pull request
Oct 10, 2023
This is the libdnf version of this patch [0] for DNF 4. Per [1], Python packages should include some minimal distribution metadata, e.g. to make the package appear in `pip list`. [0] rpm-software-management/dnf#1997 [1] https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata = changelog = msg: Add metadata for `libdnf` Python package type: bugfix
jan-kolarik
pushed a commit
to rpm-software-management/libdnf
that referenced
this pull request
Oct 10, 2023
This is the libdnf version of this patch [0] for DNF 4. Per [1], Python packages should include some minimal distribution metadata, e.g. to make the package appear in `pip list`. [0] rpm-software-management/dnf#1997 [1] https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata = changelog = msg: Add metadata for `libdnf` Python package type: bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the DNF 4 cousin to this patch [0] for DNF 5.
Per [1], Python packages should include some minimal distribution metadata, e.g. to make the package appear in
pip list.Perhaps the "proper way" to generate this dist-info metadata would be to write a pyproject.toml and use a conventional Python build system like Poetry to build
python3-dnfrather than doing it with CMake, but this is a way to do it with minimal changes to the build process.Closes RhBug:2239323 [2]
[0] rpm-software-management/dnf5#447
[1] https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata,
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2239323
= changelog =
msg: Add metadata for
dnfPython packagetype: bugfix
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2239323