Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix storing arguments in history (RhBug:1239274) #424

Merged
merged 1 commit into from Jan 7, 2016

Conversation

Projects
None yet
6 participants
@ignatenkobrain
Copy link
Member

commented Jan 7, 2016

argument for dnf.cli.configure() should be list, not map.
In python 2 map() returns list, but in python3 it is not the same, so
let's use list().

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1239274
Reported-by: Vít Ondruch vondruch@redhat.com
Tested-by: Daniele Viganò dennyvatwork@gmail.com
Tested-by: Vinicius Reis angiolucci@gmail.com
Tested-by: Martin Mézl mezlm@seznam.cz
Signed-off-by: Igor Gnatenko i.gnatenko.brain@gmail.com

cli: fix storing arguments in history (RhBug:1239274)
argument for dnf.cli.configure() should be list, not map.
In python 2 map() returns list, but in python3 it is not the same, so
let's use list().

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1239274
Reported-by: Vít Ondruch <vondruch@redhat.com>
Tested-by: Daniele Viganò <dennyvatwork@gmail.com>
Tested-by: Vinicius Reis <angiolucci@gmail.com>
Tested-by: Martin Mézl <mezlm@seznam.cz>
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@xiangzhai

This comment has been minimized.

Copy link

commented Jan 7, 2016

+1

@xenithorb

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2016

+1

Can we get this merged? The bugzilla report is pretty clear about this working

Very annoying not to be able to leverage dnf history, it's useless without this.

@kparal

This comment has been minimized.

Copy link

commented Jan 7, 2016

Thanks Igor for opening the pull request. Hopefully this will speed things up :)

@jsilhan jsilhan merged commit 2402d49 into rpm-software-management:master Jan 7, 2016

1 check passed

default Build finished.
Details
@jsilhan

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2016

Merged, thanks

@ignatenkobrain ignatenkobrain deleted the ignatenkobrain:history branch Jun 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.