cli: fix storing arguments in history (RhBug:1239274) #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argument for dnf.cli.configure() should be list, not map. In python 2 map() returns list, but in python3 it is not the same, so let's use list(). Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1239274 Reported-by: Vít Ondruch <vondruch@redhat.com> Tested-by: Daniele Viganò <dennyvatwork@gmail.com> Tested-by: Vinicius Reis <angiolucci@gmail.com> Tested-by: Martin Mézl <mezlm@seznam.cz> Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
|
+1 |
|
+1 Can we get this merged? The bugzilla report is pretty clear about this working Very annoying not to be able to leverage dnf history, it's useless without this. |
|
Thanks Igor for opening the pull request. Hopefully this will speed things up :) |
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argument for dnf.cli.configure() should be list, not map.
In python 2 map() returns list, but in python3 it is not the same, so
let's use list().
Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1239274
Reported-by: Vít Ondruch vondruch@redhat.com
Tested-by: Daniele Viganò dennyvatwork@gmail.com
Tested-by: Vinicius Reis angiolucci@gmail.com
Tested-by: Martin Mézl mezlm@seznam.cz
Signed-off-by: Igor Gnatenko i.gnatenko.brain@gmail.com