Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone for timestamps + one patch of privatization #564

Closed
wants to merge 1 commit into from
Closed

Add timezone for timestamps + one patch of privatization #564

wants to merge 1 commit into from

Conversation

j-mracek
Copy link
Member

No description provided.

@ignatenkobrain
Copy link
Contributor

Timestamp is by definition without any timezone)

@j-mracek
Copy link
Member Author

The privatization problem is fixed in separate PR

@j-mracek
Copy link
Member Author

bot test this please

@ignatenkobrain
Copy link
Contributor

@j-mracek please change description to not have "timezone" and "timestamp" in one line ;)

Something like Include timezone information for all datetime text.

@ignatenkobrain ignatenkobrain self-assigned this Aug 20, 2016
@j-mracek
Copy link
Member Author

Actually I didn't change all expressions. cli.output.py lines 1635 and 1643. There is some strange parsing and i don't want to touch it.

@j-mracek
Copy link
Member Author

@ignatenkobrain corrected

@ignatenkobrain
Copy link
Contributor

@dnf-bot r+

@dnf-bot
Copy link
Member

dnf-bot commented Aug 22, 2016

📌 Commit 04265be has been approved by ignatenkobrain

@dnf-bot
Copy link
Member

dnf-bot commented Aug 22, 2016

⌛ Testing commit 04265be with merge 8acb004...

dnf-bot pushed a commit that referenced this pull request Aug 22, 2016
@j-mracek
Include timezone information for datetime text (RhBug:1306096)
8acb004 
https://bugzilla.redhat.com/show_bug.cgi?id=1306096

Closes: #564
Approved by: ignatenkobrain
@dnf-bot
Copy link
Member

dnf-bot commented Aug 22, 2016

☀️ Test successful - status-jenkins
Approved by: ignatenkobrain
Pushing 8acb004 to master...

@dnf-bot
Copy link
Member

dnf-bot commented Aug 22, 2016

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@ignatenkobrain
Copy link
Contributor

@dnf-bot retry

@dnf-bot
Copy link
Member

dnf-bot commented Aug 22, 2016

⌛ Testing commit 04265be with merge e4f6efc...

@dnf-bot
Copy link
Member

dnf-bot commented Aug 22, 2016

☀️ Test successful - status-jenkins
Approved by: ignatenkobrain
Pushing e4f6efc to master...

@dnf-bot dnf-bot closed this in e4f6efc Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ignatenkobrain ignatenkobrain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-mracek @ignatenkobrain @dnf-bot