New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPG compatibility fix for RHEL 7. #837
GPG compatibility fix for RHEL 7. #837
Conversation
DNF can handle both pygpgme and python-gpg now.
import gpgme | ||
|
||
|
||
class Context(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8]
- [E303] too many blank lines (2)
self.ctx.armor = value | ||
|
||
def op_import(self, key_fo): | ||
if isinstance(key_fo, basestring): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8]
- [F821] undefined name 'basestring'
return getattr(self.ctx, name) | ||
|
||
|
||
class Data(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8]
- [E303] too many blank lines (2)
NO. pygpgme is unsupported and dead. We provide gpgme with bindings in our COPR repo and patch is available for EL7 package out of it. |
Reopening because we'll very unlikely get new gpgme into RHEL 7. |
import gpgme | ||
|
||
|
||
class Context(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8]
[E303] too many blank lines (2)
return getattr(self.ctx, name) | ||
|
||
|
||
class Data(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8]
[E303] too many blank lines (2)
self.ctx.armor = value | ||
|
||
def op_import(self, key_fo): | ||
if isinstance(key_fo, basestring): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8]
[F821] undefined name 'basestring'
It will also need changes in spec file, something like: %if (0%{?rhel} && 0%{?rhel} <= 7) |
@rh-atomic-bot try |
DNF can handle both pygpgme and python-gpg now. Closes: #837 Approved by: <try>
☀️ Test successful - status-papr |
📌 Commit d73ab88 has been approved by |
DNF can handle both pygpgme and python-gpg now.