Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG compatibility fix for RHEL 7. #837

Merged
merged 1 commit into from May 14, 2018

Conversation

dmach
Copy link

@dmach dmach commented Jun 6, 2017

DNF can handle both pygpgme and python-gpg now.

DNF can handle both pygpgme and python-gpg now.
import gpgme


class Context(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8]

  • [E303] too many blank lines (2)

self.ctx.armor = value

def op_import(self, key_fo):
if isinstance(key_fo, basestring):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8]

  • [F821] undefined name 'basestring'

return getattr(self.ctx, name)


class Data(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8]

  • [E303] too many blank lines (2)

@ignatenkobrain
Copy link
Contributor

ignatenkobrain commented Jun 6, 2017

NO.

pygpgme is unsupported and dead. We provide gpgme with bindings in our COPR repo and patch is available for EL7 package out of it.

@dmach
Copy link
Author

dmach commented Feb 20, 2018

Reopening because we'll very unlikely get new gpgme into RHEL 7.
This or a similar compat patch will be needed.

@dmach dmach reopened this Feb 20, 2018
import gpgme


class Context(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8]

[E303] too many blank lines (2)

return getattr(self.ctx, name)


class Data(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8]

[E303] too many blank lines (2)

self.ctx.armor = value

def op_import(self, key_fo):
if isinstance(key_fo, basestring):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Flake8]

[F821] undefined name 'basestring'

@m-blaha
Copy link
Member

m-blaha commented Mar 22, 2018

It will also need changes in spec file, something like:

%if (0%{?rhel} && 0%{?rhel} <= 7)
BuildRequires: pygpgme
Requires: pygpgme
%else
BuildRequires: python2-gpg
Requires: python2-gpg
%endif

@m-blaha
Copy link
Member

m-blaha commented Apr 26, 2018

@rh-atomic-bot try

@rh-atomic-bot
Copy link

⌛ Trying commit d73ab88 with merge cccf15a...

rh-atomic-bot pushed a commit that referenced this pull request Apr 26, 2018
DNF can handle both pygpgme and python-gpg now.

Closes: #837
Approved by: <try>
@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
State: approved= try=True

@m-blaha
Copy link
Member

m-blaha commented Apr 30, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit d73ab88 has been approved by m-blaha

@m-blaha m-blaha merged commit 2f91dbd into rpm-software-management:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants