Add URL detection for argument according prefix (RhBug:1472847) #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
reviewed
Sep 27, 2017
m-blaha
reviewed
Sep 27, 2017
dnf/cli/commands/__init__.py
Outdated
| @@ -91,6 +91,9 @@ def _checkEnabledRepo(base, possible_local_files=[]): | |||
| for lfile in possible_local_files: | |||
| if lfile.endswith(".rpm") and os.path.exists(lfile): | |||
| return | |||
| schemes = dnf.pycomp.urlparse.urlparse(lfile)[0] | |||
| if schemes and schemes in ('http', 'ftp', 'file', 'https'): | |||
There was a problem hiding this comment.
if schemes in ('http', 'ftp', 'file', 'https'):
should be enough
Also in variable schemes is only one scheme. Rename variable to singular "scheme"?
|
@rh-atomic-bot try |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 1, 2017
Additionally it reduce calls for check of available of repos if filename is present. https://bugzilla.redhat.com/show_bug.cgi?id=1472847 Closes: #898 Approved by: <try>
|
💥 Test timed out |
Additionally it reduce calls for check of available of repos if filename is present. https://bugzilla.redhat.com/show_bug.cgi?id=1472847
|
@m-blaha Refactored according to your request. If you will approve PR I will request the merge. Thanks a lot. |
m-blaha
approved these changes
Oct 3, 2017
|
📌 Commit e0862bf has been approved by |
|
☀️ Test successful - status-papr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally it reduce calls for check of available of repos if filename is
present.
https://bugzilla.redhat.com/show_bug.cgi?id=1472847