Fix command clean #921
Closed
Fix command clean #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnf-bot
reviewed
Sep 12, 2017
dnf/repo.py
Outdated
| def repo_cache_files_pattern(type, repo): | ||
| if type == 'metadata': | ||
| return r'^%s\/.*(xml(\.gz|\.xz|\.bz2)?|asc|cachecookie|%s)$' % \ | ||
| (repo._cachedir_name, dnf.repo._MIRRORLIST_FILENAME) |
There was a problem hiding this comment.
[flake8]
- [E121] continuation line under-indented for hanging indent
jrohel
force-pushed
the
fix/cmd_clean_repos
branch
from
c319ed5
to
23d4085
Compare
|
@jrohel Is it ready to review? |
|
@rh-atomic-bot try |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 26, 2017
Closes: #921 Approved by: <try>
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 26, 2017
"--allrepos" is much powerfull then "--enablerepo=*" because it works for all repositories. Eg. repositories for different release version are included. Closes: #921 Approved by: <try>
|
💥 Test timed out |
|
@rh-atomic-bot try |
|
@jrohel Is it ready to review? |
|
@rh-atomic-bot try |
jrohel
force-pushed
the
fix/cmd_clean_repos
branch
from
23d4085
to
a90eea7
Compare
Added option "--enabled".
Command "clean" cleans temporary files for all repositories by default.
Only enabled repositories are cleaned by using option "--enabled".
Option "--enabled" is automaticaly activated if list of enabled repositories
is changed from commandline ("--repo". "--enablerepo", "--disablerepo").
jrohel
force-pushed
the
fix/cmd_clean_repos
branch
from
a90eea7
to
124e144
Compare
|
@rh-atomic-bot try |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 16, 2017
Added option "--enabled".
Command "clean" cleans temporary files for all repositories by default.
Only enabled repositories are cleaned by using option "--enabled".
Option "--enabled" is automaticaly activated if list of enabled repositories
is changed from commandline ("--repo". "--enablerepo", "--disablerepo").
Closes: #921
Approved by: <try>
|
☀️ Test successful - status-papr |
|
Closing as decided in the team meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes "Bug 1330211 - RFE: dnf clean does not respect enablerepo/disablerepo anymore"
Added option "--enabled".
Command "clean" cleans temporary files for all repositories by default.
Only enabled repositories are cleaned by using option "--enabled".
Option "--enabled" will be automaticaly activated if list of enabled repositories
is changed from commandline ("--repo". "--enablerepo", "--disablerepo").