[modularity] module enabling based on rpms #951

mhatina · 2017-10-12T07:58:11Z

module list output fixed
module enabling based on rpms
do not enable module when transaction fails
enable module runtime dependencies, when enabling module:stream
accept no profile when installing module, but inform user about it
install new rpms when updating profiles
limit the width of module list command

dnf-bot · 2017-10-12T07:58:34Z

dnf/module/repo_module_dict.py

+
+                nevra = "{}-{}.{}".format(pkg.name, pkg.evr, pkg.arch)
+                if nevra in version.module_metadata.artifacts.rpms and \
+                                pkg in not_in_enabled:


[flake8]

[E127] continuation line over-indented for visual indent

dnf-bot · 2017-10-12T07:58:34Z

dnf/module/repo_module_dict.py

+                    nevra = "{}-{}:{}.{}".format(pkg.name, pkg.epoch, pkg.evr, pkg.arch)
+
+                if nevra in version.module_metadata.artifacts.rpms:
+                    print (nevra)


[flake8]

[E211] whitespace before '('

dnf-bot · 2017-10-12T08:29:31Z

dnf/module/repo_module_dict.py

        subj = ModuleSubject(module_spec)
        module_version, module_form = subj.find_module_version(self)

        self[module_version.name].enable(module_version.stream, self.base.conf.assumeyes)

-    def disable(self, module_spec):
+        if save_immediately:
+           self.base._module_persistor.commit()


[flake8]

[E111] indentation is not a multiple of four

dnf-bot · 2017-10-12T08:29:32Z

dnf/module/repo_module_dict.py

-    def disable(self, module_spec):
+        if save_immediately:
+           self.base._module_persistor.commit()
+           self.base._module_persistor.save()


[flake8]

[E111] indentation is not a multiple of four

dnf-bot · 2017-10-12T08:29:32Z

dnf/module/repo_module_dict.py

        subj = ModuleSubject(module_spec)
        module_version, module_form = subj.find_module_version(self)

        repo_module = module_version.repo_module
        repo_module.disable()

-    def lock(self, module_spec):
+        if save_immediately:
+           self.base._module_persistor.commit()


[flake8]

[E111] indentation is not a multiple of four

dnf-bot · 2017-10-12T08:29:33Z

dnf/module/repo_module_dict.py

-    def lock(self, module_spec):
+        if save_immediately:
+           self.base._module_persistor.commit()
+           self.base._module_persistor.save()


[flake8]

[E111] indentation is not a multiple of four

dnf-bot · 2017-10-12T08:29:33Z

dnf/module/repo_module_dict.py

@@ -176,9 +220,14 @@ def lock(self, module_spec):
            raise EnabledStreamException(module_spec)

        repo_module.lock(module_version.version)
+
+        if save_immediately:
+           self.base._module_persistor.commit()


[flake8]

[E111] indentation is not a multiple of four

dnf-bot · 2017-10-12T08:29:33Z

dnf/module/repo_module_dict.py

+
+        if save_immediately:
+           self.base._module_persistor.commit()
+           self.base._module_persistor.save()


[flake8]

[E111] indentation is not a multiple of four

dnf-bot · 2017-10-12T08:29:34Z

dnf/module/repo_module_dict.py

@@ -188,6 +237,11 @@ def unlock(self, module_spec):
            raise EnabledStreamException(module_spec)

        repo_module.unlock()
+
+        if save_immediately:
+           self.base._module_persistor.commit()


[flake8]

[E111] indentation is not a multiple of four

dnf-bot · 2017-10-12T08:29:35Z

dnf/module/repo_module_dict.py

+
+        if save_immediately:
+           self.base._module_persistor.commit()
+           self.base._module_persistor.save()


[flake8]

[E111] indentation is not a multiple of four

alexxa · 2017-10-18T11:34:23Z

@mhatina, can you add to a spec file that package of @ignatenkobrain which fixes module list thing, please?

mhatina · 2017-10-18T11:59:14Z

@alexxa it is in commit d2bd0f3

mhatina · 2017-10-18T12:04:45Z

@alexxa also there is a change in UI (20ca752)

dmach · 2017-10-18T12:09:32Z

@rh-atomic-bot r+

Closes: #951 Approved by: dmach

rh-atomic-bot · 2017-10-18T22:11:34Z

💔 Test failed - status-papr

ignatenkobrain · 2017-10-19T06:35:18Z

@rh-atomic-bot retry

rh-atomic-bot · 2017-10-19T06:35:23Z

⌛ Testing commit 9161336 with merge fa2702a...

Closes: #951 Approved by: dmach

rh-atomic-bot · 2017-10-19T06:37:45Z

💔 Test failed - status-papr

mhatina · 2017-10-23T07:18:11Z

@rh-atomic-bot retry

rh-atomic-bot · 2017-10-23T07:18:15Z

⌛ Testing commit 9161336 with merge 2791659...

Closes: #951 Approved by: dmach

ignatenkobrain · 2017-10-23T07:22:45Z

@mhatina, DNF is broken at this point, @j-mracek is supposed to look at it. If this is critical, just merge it by hands

ignatenkobrain · 2017-10-23T07:23:07Z

also, new python-smartcols is not yet in stable

mhatina · 2017-10-23T07:28:17Z

@ignatenkobrain ok, I will merge it by hand and inform users to enable updates-testing repo so they can update to latest python-smartcols

dnf-bot reviewed Oct 12, 2017

View reviewed changes

mhatina force-pushed the modules_12102017 branch from 2492870 to 9ed4e94 Compare October 12, 2017 08:01

dnf-bot reviewed Oct 12, 2017

View reviewed changes

mhatina force-pushed the modules_12102017 branch 2 times, most recently from beab5f9 to c0ef7ce Compare October 12, 2017 08:32

mhatina assigned dmach Oct 12, 2017

mhatina force-pushed the modules_12102017 branch 2 times, most recently from e96b318 to 2361aac Compare October 16, 2017 11:18

Martin Hatina added 6 commits October 17, 2017 09:36

refactor listing of module

5b8e5df

enable module when installing rpm

ca15924

do not enable module when transaction fails

49f5c2c

enable also module runtime dependencies

9f6209c

accept no profile when installing module, but inform user about it

e8030f8

fix failing module test

dcc2604

mhatina force-pushed the modules_12102017 branch from 2361aac to dcc2604 Compare October 17, 2017 07:51

Martin Hatina added 2 commits October 18, 2017 14:00

install new rpms when updating profiles

1896510

require smartcols >= 0.3.0

d2bd0f3

mhatina force-pushed the modules_12102017 branch from 5f04bf3 to d2bd0f3 Compare October 18, 2017 12:02

rh-atomic-bot pushed a commit that referenced this pull request Oct 18, 2017

require smartcols >= 0.3.0

777eea8

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 18, 2017

limit the width of module list command

4e2b7b8

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

refactor listing of module

fad6922

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

enable module when installing rpm

7730337

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

do not enable module when transaction fails

39a4bf3

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

enable also module runtime dependencies

c4dc020

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

accept no profile when installing module, but inform user about it

57bedd8

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

fix failing module test

64e4757

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

install new rpms when updating profiles

dfde4ee

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

require smartcols >= 0.3.0

fef6b78

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 19, 2017

limit the width of module list command

fa2702a

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

refactor listing of module

99ef40e

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

enable module when installing rpm

8eeb947

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

do not enable module when transaction fails

767a062

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

enable also module runtime dependencies

8909eef

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

accept no profile when installing module, but inform user about it

d2ef7ab

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

fix failing module test

81eab65

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

install new rpms when updating profiles

c1764cc

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

require smartcols >= 0.3.0

425ccf7

Closes: #951 Approved by: dmach

rh-atomic-bot pushed a commit that referenced this pull request Oct 23, 2017

limit the width of module list command

2791659

Closes: #951 Approved by: dmach

mhatina merged commit 7493ec8 into rpm-software-management:wip/modularity Oct 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[modularity] module enabling based on rpms #951

[modularity] module enabling based on rpms #951

mhatina commented Oct 12, 2017 •

edited

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

dnf-bot Oct 12, 2017

alexxa commented Oct 18, 2017

mhatina commented Oct 18, 2017 •

edited

mhatina commented Oct 18, 2017

dmach commented Oct 18, 2017

rh-atomic-bot commented Oct 18, 2017

ignatenkobrain commented Oct 19, 2017

rh-atomic-bot commented Oct 19, 2017

rh-atomic-bot commented Oct 19, 2017

mhatina commented Oct 23, 2017

rh-atomic-bot commented Oct 23, 2017

ignatenkobrain commented Oct 23, 2017

ignatenkobrain commented Oct 23, 2017

mhatina commented Oct 23, 2017 •

edited

[modularity] module enabling based on rpms #951

[modularity] module enabling based on rpms #951

Conversation

mhatina commented Oct 12, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexxa commented Oct 18, 2017

mhatina commented Oct 18, 2017 • edited

mhatina commented Oct 18, 2017

dmach commented Oct 18, 2017

rh-atomic-bot commented Oct 18, 2017

ignatenkobrain commented Oct 19, 2017

rh-atomic-bot commented Oct 19, 2017

rh-atomic-bot commented Oct 19, 2017

mhatina commented Oct 23, 2017

rh-atomic-bot commented Oct 23, 2017

ignatenkobrain commented Oct 23, 2017

ignatenkobrain commented Oct 23, 2017

mhatina commented Oct 23, 2017 • edited

mhatina commented Oct 12, 2017 •

edited

mhatina commented Oct 18, 2017 •

edited

mhatina commented Oct 23, 2017 •

edited