Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String should be split into multiple strings #1488

Closed
HarmfulBreeze opened this issue May 14, 2024 · 0 comments · Fixed by #1489
Closed

String should be split into multiple strings #1488

HarmfulBreeze opened this issue May 14, 2024 · 0 comments · Fixed by #1489
Assignees
@ppisar
Labels
Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@HarmfulBreeze
Copy link

Currently, msg_action cannot be translated. I believe this string should be split into multiple strings, one for each action, to make it possible to translate.

dnf5/libdnf5/rpm/transaction.cpp

Line 381 in 74d0f80

throw TransactionError(M_("Cannot {} package \"{}\""), msg_action, item.get_package().get_full_nevra());

@ppisar ppisar added Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take labels May 14, 2024
@ppisar ppisar self-assigned this May 14, 2024
ppisar added a commit to ppisar/dnf5 that referenced this issue May 14, 2024
@ppisar
i18n: Unwind "Cannot {} package \"{}\"" message
a137bca 
Correct localization depends on the first argument. This patch fixes
it by spelling the complete sentence.

Note: libdnf_assert(), libdnf_throw_assertion() cannot be
internationalized because undelying fmt::format() requires a costexpr.
Hence the formatting string cannot be computed at runtime.

Fixes rpm-software-management#1488
@ppisar ppisar mentioned this issue May 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
@ppisar
i18n: Unwind "Cannot {} package \"{}\"" message
ae824d8 
Correct localization depends on the first argument. This patch fixes
it by spelling the complete sentence.

Note: libdnf_assert(), libdnf_throw_assertion() cannot be
internationalized because undelying fmt::format() requires a costexpr.
Hence the formatting string cannot be computed at runtime.

Fixes #1488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisar ppisar

Labels
Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i18n: Unwind "Cannot {} package \"{}\"" message ppisar/dnf5
2 participants
@ppisar @HarmfulBreeze