modules: Add module goal and resolving #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Nov 4, 2022
| @@ -45,6 +45,9 @@ class ModuleGoalPrivate { | |||
|
|
|||
| libdnf::GoalProblem resolve(); | |||
|
|
|||
| size_t count_solver_problems(); | |||
| std::vector<std::vector<std::tuple<ProblemRules, Id, Id, Id, std::string>>> get_problems(); | |||
There was a problem hiding this comment.
May I ask you for a doc string?
j-mracek
reviewed
Nov 4, 2022
j-mracek
reviewed
Nov 4, 2022
|
|
||
| libdnf::solv::IdQueue list_installs(); | ||
|
|
||
| ::Transaction * get_transaction() { return libsolv_transaction; } |
There was a problem hiding this comment.
May I ask you to add docstrings for methods in class and for class itself?
j-mracek
reviewed
Nov 4, 2022
| @@ -57,6 +57,7 @@ class ModuleSack { | |||
|
|
|||
| /// Return module items in container | |||
| const std::vector<std::unique_ptr<ModuleItem>> & get_modules(); | |||
| std::vector<ModuleItem *> get_active_modules(); | |||
There was a problem hiding this comment.
Please could you add a doc string?
j-mracek
reviewed
Nov 4, 2022
| @@ -67,6 +83,8 @@ class ModuleSack { | |||
| /// @since 5.0 | |||
| std::vector<std::string> get_default_profiles(std::string module_name, std::string module_stream); | |||
|
|
|||
| std::pair<std::vector<std::vector<std::string>>, ModuleErrorType> resolve_active_module_items(bool debug_solver); | |||
There was a problem hiding this comment.
May I ask you for a doc string?
j-mracek
reviewed
Nov 4, 2022
libdnf/module/module_sack_impl.hpp
Outdated
| @@ -72,6 +72,9 @@ class ModuleSack::Impl { | |||
| // (<name>:<stream>:<context>) into active_modules. | |||
| void set_active_modules(ModuleGoalPrivate & goal); | |||
|
|
|||
| std::pair<std::vector<std::vector<std::string>>, ModuleSack::ModuleErrorType> module_solve( | |||
| std::vector<ModuleItem *> module_items, bool debug_solver); | |||
There was a problem hiding this comment.
May I ask you for a doc string?
There is no resolving yet, so no active modules, but once it's added, the methods for setting and getting active modules are already there.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.