Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repoquery: Add --what* and --exactdeps options #129

Merged
merged 4 commits into from Dec 12, 2022

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Nov 10, 2022

@kontura kontura force-pushed the repoquery_what_exact branch 2 times, most recently from 09ff3cb to eae55ba Compare November 15, 2022 09:48
@j-mracek
Copy link
Member

@kontura It looks like that there is a problem in build - failing unit tests.

@kontura
Copy link
Contributor Author

kontura commented Nov 15, 2022

yes, I am working on it.
It is really weird because it passes for me locally on all fedoras but it fails in COPR.

@kontura
Copy link
Contributor Author

kontura commented Nov 16, 2022

@j-mracek I have resolved the issue.

@jrohel jrohel self-assigned this Nov 23, 2022
@mcurlej mcurlej added this to the Fedora 38 milestone Nov 24, 2022
@kontura
Copy link
Contributor Author

kontura commented Nov 28, 2022

I have updated arguments of resolve_nevras_to_packges(...) to be const references.

@kontura
Copy link
Contributor Author

kontura commented Nov 30, 2022

Rebased to resolve conflicts.

Copy link
Contributor

@jrohel jrohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I added comments.

common/utils/string.hpp Outdated Show resolved Hide resolved
libdnf/conf/option_string_list.cpp Outdated Show resolved Hide resolved
dnf5/commands/repoquery/repoquery.cpp Outdated Show resolved Hide resolved
@kontura kontura force-pushed the repoquery_what_exact branch 2 times, most recently from 07a7135 to df27c88 Compare December 8, 2022 10:09
Using `strtok_r()` changes the `from_string()` behavior.
Empty values are now ignored (except when its first).
It showcases the behavior of `OptionStringList::from_string()` on
various examples.
@jrohel
Copy link
Contributor

jrohel commented Dec 12, 2022

Thank you for PR.

@jrohel jrohel merged commit 5f86d99 into rpm-software-management:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants