[libdnf5] Actions plugin: Add hooks repos_configured, repos_loaded, pre/post_add_cmdline_packages
#1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
changed the title
repos_configured, repos_loaded, pre/post_add_cmdline_packagesrepos_configured, repos_loaded, pre/post_add_cmdline_packages
And increases plugin version to 1.0.0
Adds `repos_configured`, `repos_loaded`, `pre_add_cmdline_packages`, `post_add_cmdline_packages` hooks into the documentation.
jrohel
force-pushed
the
libdnf_actions_plugin_add_hooks
branch
from
71dc5f5
to
dd2ffd0
Compare
|
LGTM, just please also update the docs regarding the new hooks: https://dnf5.readthedocs.io/en/latest/libdnf5_plugins/actions.8.html. |
OK, it's already mentioned there. I consider it enough, thanks. |
Merged
via the queue into
rpm-software-management:main
with commit May 13, 2024
5feb957
16 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1405 added new hooks to the ibdnf5 plugin API:
repos_configured,repos_loaded,pre_add_cmdline_packages,post_add_cmdline_packagesThis PR extends the actions plugin to support these new hooks.
Plugin version is set to 1.0.0.
Closes #1455