automatic: Fix documentation and ship config file #1476
Conversation
| # copy this file to /etc/dnf/dnf5-plugins/automatic.conf and make your | ||
| # changes there. |
There was a problem hiding this comment.
Is a full copy really necessary? With that /usr vs. /etc schema, it's usually nicer to have a file in /etc/ which merely overrides some default keys. I.e. if /etc exists, will it still read the other key defaults from /usr?
There was a problem hiding this comment.
I did not change (for now) the logic how the config files are read, merely added a distribution config file to the package. So currently the /usr config file is not being read if the /etc one exists.
But I get your point. Let me think about it till tomorrow. Meanwhile I added a blocked label to the PR.
There was a problem hiding this comment.
Thanks @m-blaha FTR, no reason to block this PR, these are good changes. I was just wondering how it works. E.g. is it legit to create an /etc config with just a single key? If I set only apply_updates = yes in /etc, how will dnf-automatic treat e.g. the value of upgrade_type? As it works right now without any config file, I guess it has some builtin defaults anyway -- and hopefully they match the default file in /usr 😁
There was a problem hiding this comment.
Yes, /usr config file just contains builtin defaults - thus it's perfectly OK to include just a single config option into /etc config file. But you are right that it's not very intuitive - user kind of expects that /usr is used as a baseline and then /etc overrides are applied on top of it.
There was a problem hiding this comment.
Thanks -- if the builtin defaults match the ones in /usr, that seems fine then. This would only mean that you can't change the one in /usr (ugh, never do that) and expect it to apply if you also have an /etc/ fiile. So this seems good enough?
There was a problem hiding this comment.
I did the change anyway (hopefully you don't mind the rebase). It seems more intuitive for the user that both config files are applied. It also enables us to adjust the default configuration in /usr if needed. Now everything should be in place and PR is ready for review.
There was a problem hiding this comment.
Very nice, also good fix for the random delay!
(FTR: rebases are how git works. I never understood some people's objections against it)
m-blaha
added
the
blocked
m-blaha
force-pushed
the
mblaha/automatic-doc
branch
from
6edf12c
to
4bfbff5
Compare
m-blaha
removed
the
blocked
|
/packit test –identifier dnf5-tests |
|
Hmm, the tests don't look good, maybe a rebase is needed... |
|
I can rebase it. But those failures are strange - completely unrelated to automatic. |
The value of random_sleep was applied before the config files were read, thus user was not able to alter its value.
Previously, only one config file was read - the first existing file from either /etc/dnf/dnf5-plugins/automatic.conf or /usr/share/dnf5/dnf5-plugins/automatic.conf. Now, the config file reading behavior has been adjusted to meet user expectations. Both files (if they exist) are read, with values from /usr being applied first to serve as the baseline configuration. Values from /etc are then applied as overrides.
- use the correct locations of the configuration files - remove mentions of not any more supported systemd units - consistently use "dnf5-automatic" or "dnf5 automatic" respecively
m-blaha
force-pushed
the
mblaha/automatic-doc
branch
from
4bfbff5
to
5817031
Compare
|
Rebased. Let's wait for results... |
Yes, most probably they are, but to be sure... Thanks! |
Resolves: #1289
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2279257
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2279258