Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs_restarting: Fix invalid reference usage #1478

Merged
merged 1 commit into from
May 13, 2024

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented May 9, 2024

current is a reference to the last item of the stack vector, which
is being used after being invalidated by the stack.pop_back() call.

Resolves: #1477

`current` is a reference to the last item of the `stack` vector, which
is being used after being invalidated by the `stack.pop_back()` call.
@m-blaha m-blaha requested a review from evan-goode May 9, 2024 13:53
Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jan-kolarik jan-kolarik added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 74d0f80 May 13, 2024
15 of 19 checks passed
@jan-kolarik jan-kolarik deleted the mblaha/needs_restarting_invalid branch May 13, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dnf5 needs-restarting -s" segfaults
3 participants