Verify transaction PGP signatures automatically #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/gpg
branch
2 times, most recently
from
6e0a566
to
612dd9a
Compare
jrohel
reviewed
Jun 12, 2023
jan-kolarik
reviewed
Jun 13, 2023
For confimation of the repo gpg key import into rpmdb use the callback from repo::RepoCallbacks class. The callback now gets KeyInfo as a parameter instead of separate key fields. Also rpm::KeyInfo and repo::Key classes were unified as they contain the same information about keys.
Instead of requiring user to run the verification manually, do the checks during `transaction.run()` call.
There was an inconsistency in what key was the user asked to confirm (short key id) and what the server waits for (full key id).
Use the same wording as dnf5 does.
jan-kolarik
approved these changes
Jun 22, 2023
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Jun 28, 2023
mkrizek
added a commit
to ansible/ansible
that referenced
this pull request
Jul 10, 2023
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Jul 10, 2023
rpm-software-management/dnf5#607 (cherry picked from commit c3af71a)
nitzmahone
pushed a commit
to ansible/ansible
that referenced
this pull request
Jul 10, 2023
) rpm-software-management/dnf5#607 (cherry picked from commit c3af71a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently signatures verification requires to manually call
transaction.check_gpg_signatures()API.This PR removes the API and changes the workflow so that the signature verification is done automatically during the transaction run.
Resolves: #556
Resolves: #574
Resolves: #557
Tests adujstments: rpm-software-management/ci-dnf-stack#1314