Use already implemented clear for COMPS_HSList (RhBug:1888343) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reimplementing clear for COMPS_HSList use comps_hslist_clear. The crash was caused by dangling pointers first and last in the COMPS_HSList (rt->subnodes) struct, function comps_hslist_clear clears them out properly. = changelog = msg: Fix a crash when clearing COMPS_ObjRTree type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1888343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reimplementing clear for
COMPS_HSListusecomps_hslist_clear.The crash was caused by dangling pointers
firstandlastin theCOMPS_HSList(rt->subnodes) struct, functioncomps_hslist_clearclearsthem out properly.
= changelog =
msg: Fix a crash when clearing COMPS_ObjRTree
type: bugfix
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1888343