Skip to content

Commit

Permalink
dnf_transaction_commit(): Remove second call to rpmtsSetVSFlags
Browse files Browse the repository at this point in the history
Remove a incorrect second call to rpmtsSetVSFlags right after disabling the
signature checking. Since rpmtsSetVSFlags returns the old flags, calling
it again with the return value from the first call would result in not
disabling anything.
  • Loading branch information
bzeller authored and Conan-Kudo committed Mar 11, 2021
1 parent dd72b0a commit 0ad9e32
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions libdnf/dnf-transaction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,6 @@ dnf_transaction_commit(DnfTransaction *transaction, HyGoal goal, DnfState *state
gboolean ret = FALSE;
gint rc;
gint verbosity;
gint vs_flags;
guint i;
guint j;
DnfState *state_local;
Expand Down Expand Up @@ -1386,8 +1385,7 @@ dnf_transaction_commit(DnfTransaction *transaction, HyGoal goal, DnfState *state
goto out;

/* no signature checking, we've handled that already */
vs_flags = rpmtsSetVSFlags(priv->ts, _RPMVSF_NOSIGNATURES | _RPMVSF_NODIGESTS);
rpmtsSetVSFlags(priv->ts, vs_flags);
rpmtsSetVSFlags(priv->ts, _RPMVSF_NOSIGNATURES | _RPMVSF_NODIGESTS);

/* filter diskspace */
if (!dnf_context_get_check_disk_space(priv->context))
Expand Down

0 comments on commit 0ad9e32

Please sign in to comment.