Do not allow 1 as installonly_limit value (RhBug:1926261) #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value 1 is confusing for users and should not be allowed as installonly_limit value. Also handling of negative values is fixed - std::stoul() does not fail on negative input in the string. = changelog = msg: do not allow 1 as installonly_limit value type: enhancement resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1926261
|
Looks good and the tests passed locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value 1 is confusing for users and should not be allowed as installonly_limit value.
Also handling of negative values is fixed - std::stoul() does not fail on negative input in the string.
= changelog =
msg: do not allow 1 as installonly_limit value
type: enhancement
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1926261
Requires: rpm-software-management/dnf#1740