filterAdvisory: match installed_solvables sort with lower_bound (RhBug:2212838) #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g:2212838) `std::lower_bound` expects that the range it operates on is sorted by the provided comparator. `lower_bound()` is used on `installed_solvables` twice, first with comparator `NameSolvableComparator` and later with `SolvableCompareAdvisoryPkgNameArch` to cover both we need to sort `installed_solvables` by name and arch. Otherwise this can lead to problems if multiple architectures of a pkg are installed. For: https://bugzilla.redhat.com/show_bug.cgi?id=2212838
|
May I ask you for test for our CI? |
|
jan-kolarik
merged commit 4b693b1
into
rpm-software-management:dnf-4-master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::lower_boundexpects that the range it operates on is sorted by the provided comparator.lower_bound()is used oninstalled_solvablestwice, first with comparatorNameSolvableComparatorand later withSolvableCompareAdvisoryPkgNameArchto cover both we need to sortinstalled_solvablesby name and arch.Otherwise this can lead to problems if multiple architectures of a pkg are installed.
For: https://bugzilla.redhat.com/show_bug.cgi?id=2212838