[conf] Add limited shell-style variable expansion #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported from the DNF 5 implementation here: rpm-software-management/dnf5#800. Adds support for ${variable:-word} and ${variable:+word} POSIX-shell-like expansions of vars. ${variable:-word} means if `variable` is unset or empty, the expansion of `word` is substituted. Otherwise, the value of `variable` is substituted. ${variable:+word} means if `variable` is unset or empty, nothing is substituted. Otherwise, the expansion of `word` is substituted. Zypper supports these expansions, see here: https://doc.opensuse.org/projects/libzypp/HEAD/structzypp_1_1repo_1_1RepoVarExpand.html For: https://bugzilla.redhat.com/show_bug.cgi?id=1789346
evan-goode
added a commit
to evan-goode/dnf
that referenced
this pull request
Sep 20, 2023
Requires rpm-software-management/libdnf#1622 This is the same test case used by the DNF 5 implementation: rpm-software-management/dnf5#800
Conan-Kudo
approved these changes
Oct 11, 2023
Conan-Kudo
merged commit fde443f
into
rpm-software-management:dnf-4-master
3 checks passed
Conan-Kudo
pushed a commit
to rpm-software-management/dnf
that referenced
this pull request
Oct 11, 2023
Requires rpm-software-management/libdnf#1622 This is the same test case used by the DNF 5 implementation: rpm-software-management/dnf5#800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from the DNF 5 implementation here: rpm-software-management/dnf5#800.
Adds support for ${variable:-word} and ${variable:+word} POSIX-shell-like expansions of vars.
${variable:-word} means if
variableis unset or empty, the expansion ofwordis substituted. Otherwise, the value ofvariableis substituted.${variable:+word} means if
variableis unset or empty, nothing is substituted. Otherwise, the expansion ofwordis substituted.Zypper supports these expansions, see here:
https://doc.opensuse.org/projects/libzypp/HEAD/structzypp_1_1repo_1_1RepoVarExpand.html
For: https://bugzilla.redhat.com/show_bug.cgi?id=1789346