goal: return reason user if transaction was assembled without resolving #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng (RhBug:1393595) This is required by dnf history cmd as it doesn't resolve undo/redo transactions and get_reason is consequently called in the transaction output.
Conan-Kudo
approved these changes
Nov 18, 2016
There was a problem hiding this comment.
Looks good to me, it fixes mga#19744 / rhbz#1393595 for me.
| @@ -1179,8 +1179,8 @@ int | |||
| hy_goal_get_reason(HyGoal goal, DnfPackage *pkg) | |||
| { | |||
| //solver_get_recommendations | |||
|
|
|||
| assert(goal->solv); | |||
| if (!goal->solv) | |||
There was a problem hiding this comment.
let's use existing @hughsie's explicit style if (goal->solv == NULL)
…resolving (RhBug:1393595)
1 similar comment
|
📌 Commit 2fb3c11 has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 21, 2016
…ng (RhBug:1393595) This is required by dnf history cmd as it doesn't resolve undo/redo transactions and get_reason is consequently called in the transaction output. Closes: #213 Approved by: ignatenkobrain
|
💥 Test timed out |
|
@ignatenkobrain The bot exploded, can someone merge this manually? |
|
@dnf-bot r+ |
|
📌 Commit 2fb3c11 has been approved by |
|
@dnf-bot retry |
|
☀️ Test successful - status-jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required by dnf history cmd as it doesn't resolve undo/redo transactions
and get_reason is consequently called in the transaction output.