Error handling when downloading repo metadata (RhBug:1594121) #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback is already set for failures for individual mirrors of mirrorlists, this adds the same for single urls. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1594121 https://bugzilla.redhat.com/show_bug.cgi?id=1515848
As a result, the message that is raised to dnf is "Failed to synchronize cache for repo..." and the original error is just logged as debug, instead of raising the original error directly.
Conan-Kudo
approved these changes
Dec 28, 2018
|
All tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.