Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create @System.solv files (RhBug:1707995) #764

Merged
merged 1 commit into from Aug 27, 2019

Conversation

j-mracek
Copy link
Member

The patch will spare some place on the disk and prevents from using
outdated data, because sometime rpmdb could change but detection could
not cache it.

Additionally caching rpmDB provide minimal minimal boost in performance.

https://bugzilla.redhat.com/show_bug.cgi?id=1707995

The patch will spare some place on the disk and prevents from using
outdated data, because sometime rpmdb could change but detection could
not cache it.

Additionally caching rpmDB provide minimal minimal boost in performance.

https://bugzilla.redhat.com/show_bug.cgi?id=1707995
@j-mracek
Copy link
Member Author

@rh-atomic-bot try

@rh-atomic-bot
Copy link

⌛ Trying commit e44303c with merge 2170565...

rh-atomic-bot pushed a commit that referenced this pull request Aug 26, 2019
The patch will spare some place on the disk and prevents from using
outdated data, because sometime rpmdb could change but detection could
not cache it.

Additionally caching rpmDB provide minimal minimal boost in performance.

https://bugzilla.redhat.com/show_bug.cgi?id=1707995

Closes: #764
Approved by: <try>
@jrohel
Copy link
Contributor

jrohel commented Aug 26, 2019

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit e44303c has been approved by jrohel

@jrohel
Copy link
Contributor

jrohel commented Aug 26, 2019

Note:
There is dnf_utils_create_sack_for_filters function in PackageKit (file pk-backend-dnf.c). It contains line:
ret = dnf_sack_load_system_repo (sack, NULL, DNF_SACK_LOAD_FLAG_BUILD_CACHE, error);
So /@System.solv disappears after this PR.
But /var/cache/PackageKit/${releasever}/hawkey/@System.solv file is still created by PackageKit.

@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
Approved by: jrohel
Pushing 2170565 to master...

@rh-atomic-bot
Copy link

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@jrohel jrohel merged commit 4365be6 into rpm-software-management:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants