using xml:base with microdnf and packagekit #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan-Kudo
requested changes
Nov 6, 2019
libdnf/dnf-package.cpp
Outdated
| * | ||
| * Returns: %TRUE if the pkg is a pkg on local or media filesystem | ||
| * | ||
| * Since: 0.37.1 |
There was a problem hiding this comment.
Can you please bump the versions here, since 0.37.2 was already released...
…865) Repository can have remote and local packages at the same time using xml:base, we have to ask the pkg if it is local. The package needs to have specified repository otherwise we cannot tell with certainty if it is local or remote. https://bugzilla.redhat.com/show_bug.cgi?id=1734350 https://bugzilla.redhat.com/show_bug.cgi?id=1717865
Repos packages attribute is solely used for path to packages cache, path to packages of a local repository is calculated using repos attribute location anyway. https://bugzilla.redhat.com/show_bug.cgi?id=1734350 https://bugzilla.redhat.com/show_bug.cgi?id=1717865
|
I managed to simplify the change. With this approach there is no need for a new attribute for packages cache or 2 new methods for controlling it. |
|
Congratulations! The build has finished successfully. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
@kontura So this is ready for review now? |
|
ah, sorry, yes I think it is 👍 |
|
📌 Commit 394edbb has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 22, 2019
…865) Repository can have remote and local packages at the same time using xml:base, we have to ask the pkg if it is local. The package needs to have specified repository otherwise we cannot tell with certainty if it is local or remote. https://bugzilla.redhat.com/show_bug.cgi?id=1734350 https://bugzilla.redhat.com/show_bug.cgi?id=1717865 Closes: #833 Approved by: Conan-Kudo
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 22, 2019
Repos packages attribute is solely used for path to packages cache, path to packages of a local repository is calculated using repos attribute location anyway. https://bugzilla.redhat.com/show_bug.cgi?id=1734350 https://bugzilla.redhat.com/show_bug.cgi?id=1717865 Closes: #833 Approved by: Conan-Kudo
|
💥 Test timed out |
|
Since the changes have been approved and the tests pass locally I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 3 functions to the API.
https://bugzilla.redhat.com/show_bug.cgi?id=1734350
https://bugzilla.redhat.com/show_bug.cgi?id=1717865