[context] Preserve additionalMetadata content (RhBug:1808677) #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
force-pushed
the
fix/context_preserve_additionalMetadata_set
branch
from
433c57f
to
03a4464
Compare
jrohel
changed the title
jrohel
force-pushed
the
fix/context_preserve_additionalMetadata_set
branch
from
03a4464
to
63ea04a
Compare
j-mracek
reviewed
Mar 6, 2020
The dnf_repo_check_internal() can creates new libdnf::Repo. This patch copies content of additionalMetadata from old repository object to the new one. The swidtags plugin adds new metadata type into additionalMetadata (which is part of libdnf::Repo) in configuration hook. Without this patch the added metadata types are not copied to the newly created repository.
jrohel
force-pushed
the
fix/context_preserve_additionalMetadata_set
branch
from
63ea04a
to
633d888
Compare
|
📌 Commit 633d888 has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
The dnf_repo_check_internal() can creates new libdnf::Repo. This patch copies content of additionalMetadata from old repository object to the new one. The swidtags plugin adds new metadata type into additionalMetadata (which is part of libdnf::Repo) in configuration hook. Without this patch the added metadata types are not copied to the newly created repository. Closes: #903 Approved by: j-mracek
|
💔 Test failed - status-papr |
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
The dnf_repo_check_internal() can creates new libdnf::Repo. This patch copies content of additionalMetadata from old repository object to the new one. The swidtags plugin adds new metadata type into additionalMetadata (which is part of libdnf::Repo) in configuration hook. Without this patch the added metadata types are not copied to the newly created repository. Closes: #903 Approved by: j-mracek
|
💔 Test failed - status-papr |
|
It seems that this is not a problem with this PR: |
|
I saw this test failing before. I suspect it is somehow connected with libnf pull requests that were moved from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dnf_repo_check_internal() can creates new libdnf::Repo. This patch
copies content of additionalMetadata from old repository object
to the new one.
The swidtags plugin adds new metadata type into additionalMetadata
(which is part of libdnf::Repo) in configuration hook. Without this
patch the added metadata types are not copied to the newly created
repository.