Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpkg is missing on f26+ #71

Closed
praiskup opened this issue May 9, 2017 · 10 comments
Closed

rpkg is missing on f26+ #71

praiskup opened this issue May 9, 2017 · 10 comments
Labels

Comments

@praiskup
Copy link
Member

praiskup commented May 9, 2017

Mock scm plugin now depends on rpkg binary (and copr-builder too) to work with dist-git lookaside cache, but that script was removed from Fedora (see https://bugzilla.redhat.com/1400592). IOW: starting from mock.fc26 this feature won't work as host machine won't have rpkg script available.

As I sort of agree that reintroducing rpkg package doesn't make much sense, I propose temporary work-around -> providing rpkg script as part of mock package.

Long term solution: Koji (and Brew) uses fedpkg-minimal vs. rhpkg-simple packages. Those packages are installed only for the purpose of building source RPM (those packages explicitly collide with fedpkg and rhpkg respectively. So, ideally we should have something like rpkg-minimal package which would suite all: Koji, Brew, Copr, Mock... So rpkg-minimal should be:

  • written in shell (or very simple C), to allow installation into minimal buildroot without dependancy pollution)
  • should have some trivial plug-in mechanism, so distributions can package upstream code and add one distribution-specific plugin file for distro-specific issues
  • rpkg-minimal must be non-colliding with fedpkg, rpkg, rhpkg, and so on ... so instead of calling /usr/bin/rpkg one should explicitly ask for /usr/bin/rpkg-minimal.

@xsuchy, @clime, @pbabinca wdyt?

@xsuchy xsuchy added the bug label May 9, 2017
@pbabinca
Copy link

pbabinca commented May 9, 2017

Fine with me. @tkdchen FIY.

@clime
Copy link
Contributor

clime commented May 9, 2017

I am ok with rpkg-minimal.

@tkdchen
Copy link

tkdchen commented May 10, 2017

Fine with me too.

What else can rpkg-minimal do besides downloading sources files from lookaside?

@clime
Copy link
Contributor

clime commented May 10, 2017

I would like to see it launching builds in COPR.

@praiskup
Copy link
Member Author

would like to see it launching builds in COPR.

By that you mean that rpkg-minimal will be used by copr?

@praiskup
Copy link
Member Author

I mean -> rpkg-minimal should be really "minimal". Ideally, there should be no copr-related code (only distribution-specific code, as a plugin).

@clime
Copy link
Contributor

clime commented May 12, 2017

From the point of mock-scm plugin, it only needs to be able to download sources.

Please, see also https://bugzilla.redhat.com/show_bug.cgi?id=1400592.

@praiskup
Copy link
Member Author

@pbabinca, while rpkg package is probably needed -- asynchronously I'm thinking about "how to merge fedpkg-minimal and rhpkg-simple" idea. What are the reasons to install those packages into "chroot" instead of having them installed on host (side-by-side with mock)?

@clime
Copy link
Contributor

clime commented Aug 5, 2017

rpkg-client-0.8 (providing 'rpkg' command-line utitility) has been pushed to stable for Fedora. It will also be available on EPEL7.

@xsuchy
Copy link
Member

xsuchy commented Aug 7, 2017

So this should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants