Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal_setarch option? #79

Closed
scop opened this issue Jun 1, 2017 · 1 comment
Closed

Remove internal_setarch option? #79

scop opened this issue Jun 1, 2017 · 1 comment

Comments

@scop
Copy link
Member

scop commented Jun 1, 2017

At least the documentation of internal_setarch is outdated in etc/mock/site-defaults.cfg: it always defaults to True, and ctypes is a hard dependency anyway.

But before I go fix the doc: is the whole option outdated? py/mock.py sets personality if it's True, but is there a downside in just always doing that?

@xsuchy
Copy link
Member

xsuchy commented Jun 1, 2017

Yes. I think it can be safely removed.

@scop scop closed this as completed in 250cc64 Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants