Skip to content

Commit

Permalink
createrepo_mod: support also non-module repositories
Browse files Browse the repository at this point in the history
The point is to make it easier for build systems, which now doesn't have
to decide what kind of repository they are creating and instead just
call `createrepo_mod` in all cases. Also, once `createrepo_c` itself
supports modules, the migration will be trivial.
  • Loading branch information
FrostyX committed Aug 10, 2020
1 parent 43b6dcd commit fc473f1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions createrepo_mod/README.md
Expand Up @@ -8,6 +8,10 @@ have the modularity support implemented in `createrepo_c` itself. See

https://bugzilla.redhat.com/show_bug.cgi?id=1816753

This tool can be used as a drop-in replacement for `createrepo_c` with
one caveat. You need to specify `<directory>` before `[options]`.
Otherwise it works fine with both module and non-module repositories.

This comment has been minimized.

Copy link
@praiskup

praiskup Aug 10, 2020

Member

I was curious why you reordered the options in copr PR.

This isn't a nice thing, but considering it is just a temporary wrapper - OK. Thank you .

This comment has been minimized.

Copy link
@FrostyX

FrostyX Aug 10, 2020

Author Member

Yep, honestly, I don't know how to fix that, without re-implementing the whole createrepo_c parser with all its parameters. If you have an idea, I would be more than happy to fix that.


Please see the official Fedora Modularity documentation for the reference of how
module repositories should be created

Expand Down
2 changes: 2 additions & 0 deletions createrepo_mod/createrepo_mod.py
Expand Up @@ -96,6 +96,8 @@ def main():
parser = get_arg_parser()
args, _ = parser.parse_known_args()
yamls = find_module_yamls(args.path)
if not yamls:
return
dump_modules_yaml(args.path, yamls)
run_modifyrepo(args.path, "gz")

Expand Down

0 comments on commit fc473f1

Please sign in to comment.