New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document RPM generator input and output format #1011
Comments
I have found what was wrong ("NAME needs to be replaced by the name choosen for the file attribute and needs to be the same as the file name of the macro file itself"). But please document the input and output format. Also in https://rpm.org/user_doc/dependency_generators.html it is first written: |
Maybe |
Um, input and output format haven't changed since beginning of times, the generator doc says: It's always been one per line, but added a note about that to the doc now. |
I don't think this is correct neither comprehensible. Let me use RubyGems requires generator as an example. If I understand the generators correctly, the generator is called, when the files are processed for the (sub)package. The files, which are matched by the In case of RubyGems, that should be the only *.gemspec file available in the package [1]. All the submitted files can be used for processing required by generator. In RubyGems, we just need to open the submitted .gemspec file and look in there for its dependencies. All the dependencies are later printed into output. The output can be multiline and it looks similarly to what would be previously written directly in .spec file, although the This is the processing done for RubyGems [2]. This at miminum prints the dependency on RubyGems [3], which is on subsequent lines followed by all the other requrements which the specific package has [4]. |
Also, I believe that |
It is better now. But still it is not clear that it must print e.g not |
Btw, there is a typo:
declare -> declared |
I have been writing an RPM generator (https://rpm.org/user_doc/dependency_generators.html) and I can't understand which output format it must have.
Script is here: https://abf.io/import/devel-rpm-generators/
It simply does not work, no provides/requires are generated, I have looked into
pkgconfigdeps.sh
, tried to make the same output format, but it still does not work. Neither stdout not stderr are printed.UPD. found ther issue and fixed it, but docs require adjustment
But, if I run it locally, it works correctly:
Just as
pkgconfigdeps.sh
:Example build log with this generator enabled: https://abf.io/build_lists/3186141
Currently the output method is:
(https://abf.io/import/devel-rpm-generators/blob/rosa2019.1/develgen.sh#lc-7)
It is like https://github.com/rpm-software-management/rpm/blob/master/scripts/pkgconfigdeps.sh#L34
Please help to understand what is wrong in https://abf.io/import/devel-rpm-generators/ . There is no documentation.
The text was updated successfully, but these errors were encountered: