Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Fix license permissions #1090

Closed
nim-nim opened this issue Feb 29, 2020 · 7 comments
Closed

RFE: Fix license permissions #1090

nim-nim opened this issue Feb 29, 2020 · 7 comments
Labels
handsfree Packaging automation and convenience RFE

Comments

@nim-nim
Copy link

nim-nim commented Feb 29, 2020

Some upstreams are very new to git and are committing license file with executable permissions (probably from windows or OSX)

rpmlint rightly points out something is suspicious

Since I can’t imagine a case where we would want to package an executable license file, please attr license files by default to 0644, so packagers do not need to sprinkle their %preps with manual chmods

@Conan-Kudo
Copy link
Member

This could be done as a buildroot policy (brp) script, couldn't it?

@pmatilai
Copy link
Member

pmatilai commented Mar 2, 2020

So... a general purpose brp-setperms [options] <path> [...] script, anyone? 😇
That could then be used for adding brp-macros for tweaking license and doc (#567) permissions, plus who knows what else.

@ffesti ffesti added this to Needs triage in Ticket Review (Outdated) Mar 3, 2020
@ffesti
Copy link
Contributor

ffesti commented Mar 5, 2020

What about an permissions macro in fileattr files to set the permission for a give file type?

@pmatilai

This comment was marked as off-topic.

@pmatilai pmatilai moved this from Needs triage to Yes in Ticket Review (Outdated) Mar 30, 2020
@pmatilai
Copy link
Member

Should be done as a part of #567.

@ffesti ffesti removed this from Yes in Ticket Review (Outdated) Jul 14, 2022
@pmatilai pmatilai added handsfree Packaging automation and convenience RFE labels Sep 14, 2023
@pmatilai pmatilai changed the title %attr license files by default RFE: %attr license files by default Sep 14, 2023
@pmatilai pmatilai changed the title RFE: %attr license files by default RFE: Fix license permissions Mar 20, 2024
@pmatilai
Copy link
Member

This should be done together with #567.

@pmatilai
Copy link
Member

Actually, makes more sense to just merge this into #567.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
handsfree Packaging automation and convenience RFE
Projects
Status: Done
Development

No branches or pull requests

4 participants