add support for zstd compressed payload #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2 (Igor Gnatenko): * Switch off from RPM_CHECK_LIB * Reference zstd from rpm.pc * Link rpmio with zstd Closes: rpm-software-management#256 Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Conan-Kudo
suggested changes
Aug 2, 2017
| @@ -8,7 +8,7 @@ Name: RPM | |||
| Description: RPM Package Manager | |||
| Version: @VERSION@ | |||
| URL: http://rpm.org | |||
| # Requires: | |||
| Requires.private: @ZSTD_REQUIRES@ | |||
There was a problem hiding this comment.
If this is linked in from librpmio, there's no reason to add Requires.private, right? We never did this for any of the others...
There was a problem hiding this comment.
well, we do for Libraries.private... but since we use pkg-config for zstd, it is better to put into Requires.private..
There was a problem hiding this comment.
this is mostly if you would like to do pkg-config --static --cflags --ldflags rpm to link RPM statically.. most likely it will not work at all due to some other issues, but this is not problem of this patchset ;)
ignatenkobrain
commented
Aug 2, 2017
| @@ -351,6 +351,9 @@ int rpmFileIsCompressed(const char * file, rpmCompressedMagic * compressed) | |||
| (magic[4] == 0x5a) && (magic[5] == 0x00)) { | |||
| /* new style xz (lzma) with magic */ | |||
| *compressed = COMPRESSED_XZ; | |||
| } else if ((magic[0] == 0x28) && (magic[1] == 0x85) && | |||
| (magic[2] == 0x2f) ) { | |||
There was a problem hiding this comment.
seems like I overlooked this useless spaces in here, will fix in a bit
ydario
pushed a commit
to bitwiseworks/rpm
that referenced
this pull request
Oct 21, 2017
v2 (Igor Gnatenko):
* Switch off from RPM_CHECK_LIB
* Reference zstd from rpm.pc
* Link rpmio with zstd
v3 (Florian Festi):
* move changes to cvtfmode into separate patches
* do not error out on wrong compression levels
* ifdef out zstdio
Closes: rpm-software-management#256
Closes: rpm-software-management#297
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.