New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: Add --nomanifests disabler #437
Comments
Um, there already is such a disabler since prehistoric times (certainly it was in 4.4.x already) and working just fine (it's even tested in the testsuite), only it's --nomanifest instead of your suggested plural. |
Good. Meanwhile I suggest you look at the refactored lib/rpminstall.c tryReadManifest(). There is no logic there preventing the call. |
You might also consider supporting manifests to be downloaded and treated like lists of urls to download. shrug |
The real problem is that there are two places where manifests are read: lib/rpminstall.c (extremely old code) should be extended to use rpmgi* argument processing, thereby removing duplicated code and simplifying rpminstall.c. Don't forget to move the popt entry from poptQV.c if/when you do so. |
RPM attempts to read CLI file arguments as a manifest if a header cannot be read from the file.
Since manifests are parsed free field, rpm behavior can become quite complex, particularly when ../../.. relative paths are parsed.
There's a slew of mostly unimportant issues (IMHO: manifests are a very minor unused feature in RPM) that can/will be discovered by fuzzing.
Hence there needs to be a means to disable manifest reading from the rpm CLI
The text was updated successfully, but these errors were encountered: