Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: differentiate file and directory dependencies using a trailing '/' #439

Closed
n3npq opened this issue Apr 26, 2018 · 1 comment
Closed
Labels

Comments

@n3npq
Copy link
Contributor

n3npq commented Apr 26, 2018

No description provided.

@n3npq
Copy link
Contributor Author

n3npq commented Apr 26, 2018

RPM has only path and directory dependencies, largely because the path canonicalization in rpmCleanPath() always strips a trailing '/' character.

Luckily, the (arguably hacky) fix is not very complicated.

  1. always over allocate paths by 1 byte to accomodate a trailing '/' (if necessary.

  2. Copy the trailing character of the input argument to rpmCleanPath() to the return value when it's a trailing '/'

The above heuristic starts to propagate a hint to the expected file type throughout rpm, thereby diffentiating dir/file dependencies with stricter tests for, say, %ghost marked paths.

@ffesti ffesti added RFC RFE and removed RFC labels Jun 18, 2018
@n3npq n3npq closed this as completed Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants