Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filenames with spaces in filelists #568

Closed
nim-nim opened this issue Oct 7, 2018 · 4 comments
Closed

Support filenames with spaces in filelists #568

nim-nim opened this issue Oct 7, 2018 · 4 comments

Comments

@nim-nim
Copy link

nim-nim commented Oct 7, 2018

So, sometimes my upstreams mix files with spaces in their release archives.

That’s unfortunately inevitable when packaging things made by creatuve people that live in the Apple world.

Unfortunately, that breaks rpm every single time, requiring manual hunting of the problem file and renaming. Please fix rpm so things like

%doc 'Bodoni Specimen.pdf'

just work as everyone expects them to.

@nim-nim nim-nim changed the title Suppo Support filenames with spaces in filelists Oct 7, 2018
@ascherer
Copy link
Contributor

ascherer commented Oct 7, 2018

Try %{quote:Bodoni Specimen.pdf}. (Off the top of my hat.)

@nim-nim
Copy link
Author

nim-nim commented Oct 7, 2018

Alas the following filelist

%doc %{quote:NeoHellenic Specimen.pdf}
%doc %{quote:OFL-FAQ.txt}

only results in

+ export LC_ALL=C
+ LC_ALL=C
+ export DOCDIR
+ /usr/bin/mkdir -p /var/lib/builder/rpmbuild/BUILDROOT/gfs-neohellenic-fonts-20090918-15.fc30.x86_64/usr/share/doc/gfs-neohellenic-fonts
+ cp -pr $'\037NeoHellenic' /var/lib/builder/rpmbuild/BUILDROOT/gfs-neohellenic-fonts-20090918-15.fc30.x86_64/usr/share/doc/gfs-neohellenic-fonts
cp: cannot stat ''$'\037''NeoHellenic': No such file or directory
+ :
+ cp -pr $'Specimen.pdf\037' /var/lib/builder/rpmbuild/BUILDROOT/gfs-neohellenic-fonts-20090918-15.fc30.x86_64/usr/share/doc/gfs-neohellenic-fonts
cp: cannot stat 'Specimen.pdf'$'\037': No such file or directory
+ :
+ cp -pr $'\037OFL-FAQ.txt\037' /var/lib/builder/rpmbuild/BUILDROOT/gfs-neohellenic-fonts-20090918-15.fc30.x86_64/usr/share/doc/gfs-neohellenic-fonts
cp: cannot stat ''$'\037''OFL-FAQ.txt'$'\037': No such file or directory

@pmatilai
Copy link
Member

pmatilai commented Oct 8, 2018

Double quotes is what %files has always supported, and it works for %doc too nowadays.
In rpm < 4.11, %doc quoting differed from everything else as it was passed to shell and people used all sorts of creative hacks...

@pmatilai pmatilai closed this as completed Oct 8, 2018
@nim-nim
Copy link
Author

nim-nim commented Oct 9, 2018

Of course Panu is right and the one kind of quoting I had forgotten to check was the right one. sigh Thanks and sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants