bad version comparison in all rpm

[fedya]

example

#include <iostream>
#include <stdint.h>
#include <rpm/rpmlib.h>

int main() {
  const char * version1 = "0.13-5";
  const char * version2 = "0.13.1-5";

  int result = rpmvercmp(version1, version2);
  if (result == -1)
    std::cout << version1 << " < " << version2 << std::endl;;
  if (result == 0)
    std::cout << version1 << " = " << version2 << std::endl;;
  if (result == 1)
    std::cout << version1 << " > " << version2 << std::endl;;
}

# g++ shit.cc -lrpm
# ./a.out

result: 0.13-5 > 0.13.1-5
What is definetly wrong.
Same in RPM5.

but

# rpmdev-vercmp 0.13-5 0.13.1-5
# 0.13-5 < 0.13.1-5

works fine

[mlschroe]

No, that's correct. The - character compares the same as the . character, and 5 is greater than 1.

The rpmvercmp function only compares the version or the release parts. You need to split the input into epoch/version/release and then do individual rpmvercmp calls.

[mlschroe]

(See also issue #561 )