Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move check from rpmlint spec parser to spec-cleaner as autofixes #233

Closed
scarabeusiv opened this issue Jun 7, 2018 · 4 comments
Closed

Move check from rpmlint spec parser to spec-cleaner as autofixes #233

scarabeusiv opened this issue Jun 7, 2018 · 4 comments
Assignees
@scarabeusiv
Labels
enhancement

Comments

@scarabeusiv
Copy link
Contributor

rpmlint spec parser does check for more errors than we do in spec-cleaner, we should mimic the content and directly fix it.
@scarabeusiv
Copy link
Contributor Author

https://github.com/rpm-software-management/rpmlint/blob/master/SpecCheck.py

@scarabeusiv
Copy link
Contributor Author

scarabeusiv commented Jun 7, 2018 •
edited
Loading

  • comparison-operator-in-deptoken
  • non-break-space
  • make-check-outside-check-section
  • rpm-buildroot-usage
  • setup-not-in-prep
  • buildprereq-use
  • broken-syntax-in-scriptlet-requires
  • buildarch-instead-of-exclusivearch-tag
  • deprecated-grep
  • non-utf8-spec-file

@scarabeusiv scarabeusiv self-assigned this Jun 7, 2018
scarabeusiv pushed a commit that referenced this issue Jun 7, 2018
Prune nbsp for normal space wrt issue #233
5360459
scarabeusiv pushed a commit that referenced this issue Jun 8, 2018
Remove deprecated greps wrt issue #233
7800228
scarabeusiv pushed a commit that referenced this issue Jun 8, 2018
Remove BuildPreReq wrt issue #233
a5904f9
@scarabeusiv
Copy link
Contributor Author

  • Make check is pointless - even borked on the rpmlint side
  • Setup not in prep - even tho it works I tried it on all specs we have in distro and it was not done..

@scarabeusiv
Copy link
Contributor Author

  • rpm buildroot usage is out as osc does not allow shorted builds

scarabeusiv pushed a commit that referenced this issue Jun 8, 2018
Test for Requires(post,preun) syntax issue #233
646005e 
This is accepted by all recent rpm's, warnings were added before
in 2006 at rpm-software-management/rpmlint@2d18e47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scarabeusiv scarabeusiv

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scarabeusiv