Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pwdutils with shadow #247

Closed
jubalh opened this issue Apr 26, 2019 · 1 comment · Fixed by #252
Closed

Replace pwdutils with shadow #247

jubalh opened this issue Apr 26, 2019 · 1 comment · Fixed by #252
Labels
enhancement

Comments

@jubalh
Copy link

jubalh commented Apr 26, 2019

Would be awesome if spec-cleaner could replace pwdutils with shadow.
Maybe not in case of suse_version guard around it, since some packages like to do:

%if 0%{?suse_version} <= 1140
Requires(pre):  pwdutils
%else
Requires(pre):  shadow
%endif

See bsc#1130588.
kstreitova added a commit to kstreitova/spec-cleaner that referenced this issue Jun 28, 2019
@kstreitova
Replace pwdutils with shadow in Requires
d39df7d 
It replaces 'pwdutils' with 'shadow' in 'Requires' and 'Requires(<phase>)'
if we are not in a minimal mode and if we are not in any condition (conditions
can be tricky as we don't know their logic so replacing there can be dangerous).
Closes rpm-software-management#247
@kstreitova kstreitova mentioned this issue Jun 28, 2019
Merged
scarabeusiv pushed a commit that referenced this issue Jul 1, 2019
@kstreitova @scarabeusiv
Replace pwdutils with shadow in Requires
c23d140 
It replaces 'pwdutils' with 'shadow' in 'Requires' and 'Requires(<phase>)'
if we are not in a minimal mode and if we are not in any condition (conditions
can be tricky as we don't know their logic so replacing there can be dangerous).
Closes #247
@jubalh
Copy link
Author

jubalh commented Jul 1, 2019

Cool! Thanks!

kstreitova added a commit that referenced this issue Jul 19, 2019
@kstreitova
Remove requires from category_to_re
fab7f6a 
Requires has a special match now - pwdutils -> shadow replacement (issue #247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace pwdutils with shadow in Requires kstreitova/spec-cleaner
3 participants
@scarabeusiv @jubalh @kstreitova