Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong replacement BuildArch to ExclusiveArch #289

Closed
mimi1vx opened this issue Dec 18, 2020 · 2 comments
Closed

Wrong replacement BuildArch to ExclusiveArch #289

mimi1vx opened this issue Dec 18, 2020 · 2 comments

Comments

@mimi1vx
Copy link
Contributor

mimi1vx commented Dec 18, 2020

ExclusiveArch:  i586 i686
BuildArch:      i686
%{expand:%%global optflags %(echo "%{optflags}"|sed -e s/i586/i686/) -march=i686 -mtune=generic}
%endif

is transformed by spec-cleaner to:

%ifarch %{ix86}
ExclusiveArch:  i586 i686
ExclusiveArch:  i686
%{expand:%%global optflags %(echo "%{optflags}"|sed -e s/i586/i686/) -march=i686 -mtune=generic}
%endif
@kstreitova
Copy link
Contributor

Actually, it's not wrong. The only allowed value of BuildArch is "noarch", so the spec-cleaner automatically transforms any BuildArch with no "noarch" to ExclusiveArch as this is probably what the writer wanted to do.

@kstreitova
Copy link
Contributor

Talked to @mimi1vx and we decided that we can close this issue as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants