recognize unittest calls #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also please provide testcase with expected before and after lines. |
|
Hmm only question i now have is why it eats up that -v param that is no longer part of the pyunittest macro due to the issues it caused. Shouldn't it keep that? |
|
you are right, maybe it should keep it to preserve the behaviour before/after. It also eats the 'discover' command, inwhich case it is unclear to me whether it should preserve it as well. Pro: even less possible changes in the behaviour Contra: weird looking (and longer) command in spec. |
|
I got an information the discovery is already in the definition of the macro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are new macros %pyunittest and %pyunittest_arch in python-rpm-macros. Recognize the calls in *spec files.
It should break only few things, if any.