Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new script for rpmlint. #286

Merged

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Oct 20, 2020

The script is used to generate licenses.toml configuration
file consumed by rpmlint.

@marxin marxin force-pushed the rpmlint-new-licenses-script branch 2 times, most recently from 299ccbc to 248e0aa Compare October 20, 2020 17:02
@scarabeusiv
Copy link
Contributor

Makefile should generate the file like the licenses list then.

Also why don't you use fstrings f'{variable}'?

@marxin marxin force-pushed the rpmlint-new-licenses-script branch from 248e0aa to fe0a15c Compare October 20, 2020 17:44
@marxin
Copy link
Contributor Author

marxin commented Oct 20, 2020

Makefile should generate the file like the licenses list then.

Added.

Also why don't you use fstrings f'{variable}'?

I'm not familiar with that, but I'll learn it. I promise!
And I changed that in the pull request.

@scarabeusiv
Copy link
Contributor

You don't have to gitignore the file i would say, we can keep it in the scm and regenerate it on releases. Then you can fetch it from releases/git here and not rely on it anywhere else?

@scarabeusiv
Copy link
Contributor

All the conversion tables afterall are generated and we keep them stored.

@scarabeusiv
Copy link
Contributor

Also what the ... is again with coveralls, i start to hate that package, every 3 months different approach on how to add the stuff...

@marxin marxin force-pushed the rpmlint-new-licenses-script branch from fe0a15c to 414330e Compare October 21, 2020 09:41
@marxin
Copy link
Contributor Author

marxin commented Oct 21, 2020

All the conversion tables afterall are generated and we keep them stored.

Done that.

@marxin marxin force-pushed the rpmlint-new-licenses-script branch from 414330e to 0868724 Compare October 21, 2020 09:46
The script is used to generate licenses.toml configuration
file consumed by rpmlint.
@marxin marxin force-pushed the rpmlint-new-licenses-script branch from 0868724 to e145f0f Compare October 21, 2020 09:58
@marxin
Copy link
Contributor Author

marxin commented Oct 21, 2020

I also removed the strange First line from data/licenses_changes.txt file.

@scarabeusiv scarabeusiv merged commit d3ca53f into rpm-software-management:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants