Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Raise an exception if abidiff finds new symbols and the full name hasn't incremented its version #1100

Open
gordonmessmer opened this issue Feb 26, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@gordonmessmer
Copy link

I'm developing a new feature for rpm that will provide versioned dependencies for libraries that don't provide versioned symbols. This feature is intended to make selective updates and package installation more reliable. In order to support that feature, I would like rpminspect's abidiff test to optionally provide a non-passing result if new symbols are found, but the version of the "full name" of the library hasn't incremented.

rpm-software-management/rpm#2372

I'm willing to work on such a feature. What would an acceptable submission look like?

@dcantrell dcantrell added the enhancement New feature or request label Mar 15, 2023
@dcantrell
Copy link
Collaborator

I think this can just be an extension to the existing abidiff inspection. If the functionality is optional, it's likely worth adding a setting for it in the config file so that users can enable it or disable it. I would add that under the abidiff section. In the abidiff inspection, you would act if that setting is enabled and then do the checking and reporting for each shared object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants