Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: Add ability to exclude subpackages in emptyrpm test #355

Closed
rvykydal opened this issue Apr 9, 2021 · 2 comments
Closed

RFE: Add ability to exclude subpackages in emptyrpm test #355

rvykydal opened this issue Apr 9, 2021 · 2 comments
Assignees
@dcantrell
Labels
enhancement New feature or request v1.5

Comments

@rvykydal
Copy link

rvykydal commented Apr 9, 2021

In Anaconda we have metapackages (anaconda, anaconda-install-env-deps, anaconda-install-img-deps) that shouldn't make the check fail.
Like in rpminspect-fedora -v -T emptyrpm anaconda-35.11-1.fc35
@rvykydal rvykydal changed the title RFE: Add ability to exclude subpackages in emptyrpm test RFE: Add ability to exclude subpackages in emptyrpm test Apr 9, 2021
@rvykydal rvykydal changed the title RFE: Add ability to exclude subpackages in emptyrpm test RFE: Add ability to exclude subpackages in emptyrpm test Apr 9, 2021
@dcantrell dcantrell self-assigned this Apr 9, 2021
@dcantrell dcantrell added enhancement New feature or request v1.5 labels Apr 9, 2021
@dcantrell
Copy link
Collaborator

OK, I have a patch for the emptyrpm inspection where you can list expected empty RPMs in the rpminspect.yaml file. For anaconda, I did this locally and ran rpminspect again:

---
emptyrpm:
    expected_empty:
        - anaconda
        - anaconda-install-env-deps
        - anaconda-install-img-deps

rpminspect will still report the empty payloads, but they will be classified as INFO and it will say the empty payload is expected per the configuration file.

dcantrell added a commit that referenced this issue Apr 26, 2021
@dcantrell
[lib] Support a list of expected empty RPMs in the config file (#355)
c2522fe 
Some packages build meta packages which have empty payloads but serve
as a way to control what packages are installed.  This patch adds a
way to list the expected empty RPMs so the emptyrpm inspection still
runs, but does not fail when it encounters expected empty packages.

Signed-off-by: David Cantrell <dcantrell@redhat.com>
@rvykydal
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcantrell dcantrell

Labels
enhancement New feature or request v1.5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcantrell @rvykydal