Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
When I'm running the rpminspect in a pipeline, the pipeline can't distinguish between failing tests and the failing execution of rpminspect. In both cases, rpminspect returns exit code 1.
Example of valid execution of failing tests with "BAD" result:
Example of invalid execution:
I think this is a reasonable idea. For the example given, running rpminspect in Fedora on symlinks-1.4-10.el7 will fail unless you are providing an rpminspect.conf file which directs rpminspect to the internal brew instance so it can look up that build (the '-o results' captures the message, but that's my guess as to what's happening).
Rather than extending the -t option, I think there should be 3 exit codes for rpminspect. Similar to a program like grep. In the case of rpminspect:
Expand beyond EXIT_SUCCESS and EXIT_FAILURE. Reserve code 0 for inspection success, or all inspections passed per the result threshold. Code 1 means at least one inspection failed with regard to the result threshold. And code 2 means rpminspect errored in some way or you messed up with your input.