[fix] In the symlinks inspection, honor transitive Requires #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A package with automatic shared library dependencies usually require
an explicit Requires on the %{name} = %{version}-%{release}. This is
done to ensure subpackages don't drift from the main package when
performing upgrades. However, it is also possible to have those
explicit Requires handled by transitive Requires. That is having an
explicit Requires on a package that then itself has an explicit
Requires on the package you need. This commit implements that check
when looking for explicit Requires and treats it as satisifed.
Fixes: rpminspect#1231
Signed-off-by: David Cantrell <dcantrell@redhat.com>
evan-goode
reviewed
Dec 1, 2023
Yes, it does. I'm fixing up the test suite and adding some new tests for the transitive explicit Requires handling. |
If we find our explicit Requires in the transitive search loop, go ahead and break out early. Signed-off-by: David Cantrell <dcantrell@redhat.com>
The transitive list may be empty when we reach this while loop, so don't assume it actually has anything in it. Signed-off-by: David Cantrell <dcantrell@redhat.com>
Signed-off-by: David Cantrell <dcantrell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A package with automatic shared library dependencies usually require an explicit Requires on the %{name} = %{version}-%{release}. This is done to ensure subpackages don't drift from the main package when performing upgrades. However, it is also possible to have those explicit Requires handled by transitive Requires. That is having an explicit Requires on a package that then itself has an explicit Requires on the package you need. This commit implements that check when looking for explicit Requires and treats it as satisifed.
Fixes: #1231