[fix] Support per-file allowed lists for the badfuncs inspection #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some programs and libraries deliberately use functions that have been
deemed forbidden by policy. An example would be a library providing
runtime support for older software. In cases like this, you can
specify an allowed block listing path globs and the specific forbidden
functions they are allowed to use. It is adviseable to add a comment
idnicating why the forbidden function is allowed so future readers
will understand why the rpminspect.yaml file is configured that way.
The path specifications can be explicit paths (local path notation,
relative to /) or patterns that are compatible with fnmatch(3) and
glob(3).
For example:
---
badfuncs:
allowed:
/usr/sbin/somenetcmd:
- inet_aton
- gethostbyname
/usr/lib*/libsomething.so.*:
- inet_network
You can place this block in the package's rpminspect.yaml file to
further control how the badfuncs inspection works for your build.
Fixes: rpminspect#573
Signed-off-by: David Cantrell <dcantrell@redhat.com>
jimbair
approved these changes
Jun 23, 2022
|
Thank you. I'm finally trying this in https://src.fedoraproject.org/rpms/python3.11/pull-request/65 -- hoping the CI installs rpminspect from your copr. |
|
It says "rpminspect version 1.10" but badfuncs fails. Am I doing it wrong? |
I was doing it wrong. Trying again. |
|
Same resuts. |
DaanDeMeyer
pushed a commit
to DaanDeMeyer/python-rpm
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some programs and libraries deliberately use functions that have been
deemed forbidden by policy. An example would be a library providing
runtime support for older software. In cases like this, you can
specify an allowed block listing path globs and the specific forbidden
functions they are allowed to use. It is adviseable to add a comment
idnicating why the forbidden function is allowed so future readers
will understand why the rpminspect.yaml file is configured that way.
The path specifications can be explicit paths (local path notation,
relative to /) or patterns that are compatible with fnmatch(3) and
glob(3).
For example:
You can place this block in the package's rpminspect.yaml file to
further control how the badfuncs inspection works for your build.
Fixes: #573
Signed-off-by: David Cantrell dcantrell@redhat.com