Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontawesome Source #78

Closed
Mondrethos opened this issue Jan 27, 2024 · 1 comment · Fixed by #127
Closed

Fontawesome Source #78

Mondrethos opened this issue Jan 27, 2024 · 1 comment · Fixed by #127

Comments

@Mondrethos
Copy link
Contributor

@Alteras1,

On the live site, I believe we include the Fontawesome CDN at the top of the PAGE_HEADER Template and call it a day.

On discourse, we've been trialing on T since 2020 this plugin:

https://meta.discourse.org/t/discourse-fontawesome-pro/150871

Cons:

  • Only supports 5
  • Limited to Dev Support

Alternatives:

  • Download the CSS Project from the website with our pro license (but I don't think we can share it with our open source project?). We could add it as a theme component (repo) like the style component but private, to provide the CSS just for that.
  • We can use the CDN like we do currently on the live site.
@Alteras1
Copy link
Contributor

since we plan on adding a [fa] tag, we can ingest the font awesome setup to be part of the plugin itself, no need for separate theme component

@Alteras1 Alteras1 linked a pull request Jul 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants