Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winpty_open segfault #80

Closed
rprichard opened this issue Jun 1, 2016 · 0 comments
Closed

winpty_open segfault #80

rprichard opened this issue Jun 1, 2016 · 0 comments
Labels
bug

Comments

@rprichard
Copy link
Owner

I noticed this while working on the pty4j<->winpty integration. Very intermittently, winpty_open segfaulted.

On a different occasion, I saw an error:

[94224.745 java.exe,p6848,t7684]: libwinpty error: code=5 msg='finishSecurityDescriptor: SetEntriesInAcl failed: 87'

87 is ERROR_INVALID_PARAMETER.

I reviewed the DACL code in WindowsSecurity.cc and noticed that the two std::array<EXPLICIT_ACCESSW, ...> daclEntries fields were only partially initialized. Default-initializing an std::array<EXPLICIT_ACCESSW, ...> object leaves the bytes indeterminate.

The fix is trivial.
@rprichard rprichard added the bug label Jun 1, 2016
rprichard added a commit that referenced this issue Jun 1, 2016
@rprichard
Zero-initialize the EXPLICIT_ACCESSW objects.
cfb0728 
This may have fixed a segfault in winpty_open.

Fixes #80
@Tyriar Tyriar mentioned this issue Jan 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rprichard