Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sadd and srem raise deprecation warnings with single key #35

Closed
wants to merge 2 commits into from
Closed

sadd and srem raise deprecation warnings with single key #35

wants to merge 2 commits into from

Conversation

benlangfeld
Copy link
Contributor

@benlangfeld benlangfeld commented Jan 17, 2023 •
edited
Loading

This is necessary for compatibility with v4.7.x of the redis gem, though it is not a complete fix. I suggest merging #36 first and then this PR turning into an attempt to provide compatibility with < 5.0.

This was referenced Jan 17, 2023
Open
Closed
@garettarrowood garettarrowood marked this pull request as ready for review January 18, 2023 13:46
@benlangfeld benlangfeld marked this pull request as draft January 18, 2023 14:34
benlangfeld added a commit to powerhome/modis that referenced this pull request Jan 18, 2023
@benlangfeld
Compatibility with redis 4.7.x gem
2864b10 
It's not clear why this complexity was added in rpush#32 but it was unnecessary and breaks the test suite with redis 4.7.1. Removing it continues with tests passing on 4.6.0 and fixes the tests with 4.7.1.

Compatibility with redis 4.8.x will come in rpush#35.

See rpush#36.
@benlangfeld benlangfeld mentioned this pull request Jan 18, 2023
Merged
benlangfeld added a commit to powerhome/modis that referenced this pull request Feb 1, 2023
@benlangfeld
Compatibility with redis 4.7.x gem
e103761 
It's not clear why this complexity was added in rpush#32 but it was unnecessary and breaks the test suite with redis 4.7.1. Removing it continues with tests passing on 4.6.0 and fixes the tests with 4.7.1.

Compatibility with redis 4.8.x will come in rpush#35.

See rpush#36.
benlangfeld added a commit that referenced this pull request Feb 1, 2023
@benlangfeld
Compatibility with redis 4.7.x gem (#39)
8c4c38a 
It's not clear why this complexity was added in
#32 but it was unnecessary and breaks
the test suite with redis 4.7.1. Removing it continues with tests
passing on 4.6.0 and fixes the tests with 4.7.1.

Compatibility with redis 4.8.x will come in
#35.

See #36.
@benlangfeld benlangfeld closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@benlangfeld