-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single Table Inheritance apparently not working properly with Redis store #147
Comments
@haslo any work arounds until this is fixed? |
I have a fix for this here: rpush/modis@3d7f0b3 However, it changes the internal structure Rpush uses to support STI, so I still need to add support for migrations to Modis..... (I'm going to hell for this! 😢 😭) |
@antulik I made rpush/modis#2 as a somewhat hacky workaround. It doesn't change the storage structure, but has a bit of a performance impact, particularly with wide STI trees. |
@haslo thx, will give it a shot 👍 |
any updates on this? It's been a year and a half and the patch in modis still isn't released... we ended up working around this by patching |
@avolkovi it's been a while, seems like i've given apps prefixed names like "ios_app" or "android_app" and search only by name instead of a class. |
Should be fixed now, with rpush/modis@3d7f0b3 - I did close my PR, but not the issue, and nobody else did either... @ileitch, you wanna close this issue? |
Seems this was resolved, closing. |
We have a similar error to #136 (and maybe #127). We're not using ActiveRecord but rather Redis for storage. The bug was not reproducible with ActiveRecord storage in sqlite3 when I tried that.
to_binary
bug from Rpush selectively sends notifications. Why? #136 showing up for some of our notifications to Gcm. I found that it happens only when I actually have an APNs app in the storage - tryingRpush.push
will result in the APNs path being executed andto_binary
being called.Rpush.apns_feedback
with any apps that aren't APNs apps in the storage. They'll be iterated through and will have problems withenvironment
being nil.I think that both bugs come down to this reproducible test case (I've made a new Rails app to reproduce it, with minimal gems):
https://github.com/haslo/rpush_redis_bug
Essentially, every app is in the list of all apps (including all GCM apps being in the list of APNs apps and vice versa), and every notification is in the list of all notifications (thus iterating over all GCM notifications will return plenty of APNs notifications etc.).
The text was updated successfully, but these errors were encountered: